Skip to content

Conversation

MarcelGeo
Copy link
Contributor

Resolves #241

  • improved changes handling
  • introduce limits as in related ticket

max 10GB of non versioned files
max 5GB of versioned files
@MarcelGeo MarcelGeo changed the title Changes limits Upload changes limits Sep 11, 2025
@MarcelGeo MarcelGeo changed the base branch from master to push-v2-integration September 11, 2025 16:08
@MarcelGeo MarcelGeo requested a review from varmar05 September 12, 2025 09:44
@coveralls
Copy link

coveralls commented Sep 15, 2025

Pull Request Test Coverage Report for Build 17767076014

Details

  • 99 of 112 (88.39%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 80.639%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/test/test_local_changes.py 28 41 68.29%
Files with Coverage Reduction New Missed Lines %
mergin/client.py 1 87.18%
Totals Coverage Status
Change from base Build 17669723040: 0.3%
Covered Lines: 3965
Relevant Lines: 4917

💛 - Coveralls

@MarcelGeo MarcelGeo requested a review from varmar05 September 16, 2025 13:36

MAX_UPLOAD_CHANGES = 100


# The custom exception
class ChangesValidationError(Exception):
def __init__(self, message, invalid_changes=[], max_media_upload_size=None, max_versioned_upload_size=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pass max sizes here? It kind of constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impose non geodiff push limits
3 participants